Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

移除 <windows.h> 依赖 #53

Open
FrankHB opened this issue Oct 15, 2020 · 2 comments
Open

移除 <windows.h> 依赖 #53

FrankHB opened this issue Oct 15, 2020 · 2 comments

Comments

@FrankHB
Copy link

FrankHB commented Oct 15, 2020

这应该只是内部实现细节,不是公开 API 。(特别是考虑先前非 Windows 版本。)

因为头文件污染了大量的名称,在一般 Win32 程序中包含 <windows.h> 也是不被鼓励的。最好能够直接移除,或者至少使用 WIN32_LEAN_AND_MEAN 。如果需要,用户可以自行包含。

这也更直接地解决了 #52 的问题。

@royqh1979
Copy link
Collaborator

royqh1979 commented Oct 17, 2020

现在给vc的二进制版本依赖windows.h里各个头文件的pragma标签来自动链接对应的库。
要改这个的话需要改vc下的安装和编译流程。
还有就是因为ege里面很多常量来自wingdi.h,这个头文件里面也有一些函数定义。如果能一起去掉就更好了

@FrankHB
Copy link
Author

FrankHB commented Oct 21, 2020

#pragma 可以单独拿出来。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants