Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Sass @import #353

Open
nnagewad opened this issue Nov 19, 2024 · 1 comment
Open

Replace Sass @import #353

nnagewad opened this issue Nov 19, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@nnagewad
Copy link

nnagewad commented Nov 19, 2024

Deprecation warning about Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

Issue seems to exist within: govuk-eleventy-plugin > lib > govuk.scss.
govuk.scss

More info on the change can be found on Sass documentation: https://sass-lang.com/documentation/breaking-changes/import/

@paulrobertlloyd
Copy link
Collaborator

I’d like to update to using @use here and in many, many other projects, now that this deprecation is being announced. Yet, in early attempts to try and get this working, it seems upstream projects need to be using the module system as well, else it all breaks down. Am still trying to get my head around it, to be honest.

In that respect, I think the first place to start making changes is in the other X-GOVUK projects this project depends on.

@paulrobertlloyd paulrobertlloyd added this to the 7.0 milestone Nov 20, 2024
@paulrobertlloyd paulrobertlloyd added enhancement New feature or request dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants