Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.com/gopacket/gopacket #33

Open
chancez opened this issue Jul 23, 2024 · 2 comments
Open

Use github.com/gopacket/gopacket #33

chancez opened this issue Jul 23, 2024 · 2 comments

Comments

@chancez
Copy link

chancez commented Jul 23, 2024

Wondering if you would be willing to take contributions to switch to github.com/gopacket/gopacket. I was reviewing https://github.com/mozillazg/ptcpdump and noticed their fork of the repo master...mozillazg:pktdump:master and figured it might make sense to get the changes upstreamed, otherwise I'll just fork their fork, for my own project, but it would be nice to avoid so many forks for such simple changes.

@x-way
Copy link
Owner

x-way commented Jul 30, 2024

Yes, switching to gopacket/gopacket makes sense. Can you send me a PR? I'll happily review and integrate it 👍

@chancez
Copy link
Author

chancez commented Jul 30, 2024

@x-way sure I'll try and do that sometime this week if I can find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants