Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perspective correction controlled through OSC #35

Open
ibiltari opened this issue Feb 18, 2020 · 3 comments
Open

Perspective correction controlled through OSC #35

ibiltari opened this issue Feb 18, 2020 · 3 comments

Comments

@ibiltari
Copy link
Contributor

Hi, for an upcoming project (https://github.com/stagesoft) we need this feature and we are planning to implement it on xjadeo, perhaps it could be interesting to include it in the main branch like the other art related features?

@x42
Copy link
Owner

x42 commented Feb 18, 2020

xjadeo does not have any perspective control to begin with, so it cannot be exposed via OSC.

You could probably implement this for the openGL variants in opengl_draw (in display_gl_common.h), changing the coordinates of the GL_QUADS.

@ibiltari
Copy link
Contributor Author

Yes thanks!, i'm trying to implement it just like that, modifying the glTexCoord2f of the plane.

I have it working and exposed trough OSC, now im working in the correct texture projection mapping so it can be successfully used to correct perspective from a physical projector.

My main question was about if you think it could be and interesting addition and i should try to integrate the code with IFDEF's like the other "art" features so i could generate a pull request when ready and tested. It would be nice for us because we are planning on integrating xjadeo in another open source project and we need this feature.

@x42
Copy link
Owner

x42 commented Feb 18, 2020

That does sound great! PR is definitely welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants