Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/data/player_response.html should be removed and replaced #61

Open
oalders opened this issue Sep 22, 2020 · 0 comments
Open

t/data/player_response.html should be removed and replaced #61

oalders opened this issue Sep 22, 2020 · 0 comments

Comments

@oalders
Copy link
Collaborator

oalders commented Sep 22, 2020

See discussion at 358223b#r42587661

Basically, we don't want to run into any issues around infringement. The safest way to do this would probably be to remove t/data/player_response.html and update the test in question to use a different file for mocking -- one which contains the structure which we need for the test, but which doesn't appear to be a copy/paste of output from a 3rd party.

oalders referenced this issue Sep 22, 2020
also pass CI
additional test of new path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant