Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Forms 3.3: TextDecorations aren't unset by a DataTrigger #4121

Closed
davidbritch opened this issue Oct 18, 2018 · 7 comments
Closed

Forms 3.3: TextDecorations aren't unset by a DataTrigger #4121

davidbritch opened this issue Oct 18, 2018 · 7 comments
Labels
excellent-report help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! p/Android p/iOS 🍎 p/UWP up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@davidbritch
Copy link

Description

In Forms 3.3, TextDecorations aren't unset by a DataTrigger, unlike FontAttributes, which are.

Steps to Reproduce

  1. Run the attached sample.
  2. Browse to the "Basic Switch Bindings" page.
  3. Toggle the italic/bold switches on/off and the text appearance changes as expected.
  4. Toggle the underline or strikethrough switches on/off.

Expected Behavior

The text is underlined/receives strikethrough, and when toggling the switches to off the text decoration is undone.

Actual Behavior

The text is underlined/receives strikethrough, but the text decoration remains when toggling the switches to off.

Basic Information

  • Version with issue: 3.3 -pre3.
  • IDE: VSMac
  • Platform Target Frameworks:
    • iOS: 12.0
    • Android: API 27.
    • UWP: Not tried.
  • Android Support Library Version: 27.0.2.1

Screenshots

Underline switch toggled on:

simulator screen shot - iphone 8 - 2018-10-18 at 10 26 07

Underline switch toggled off:

simulator screen shot - iphone 8 - 2018-10-18 at 10 26 12

Reproduction Link

SwitchDemo.zip
@hartez hartez added the p/UWP label Oct 19, 2018
@alanag13 alanag13 mentioned this issue Nov 7, 2018
Closed
3 tasks
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Apr 17, 2019
@samhouts samhouts added help-wanted up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! help wanted We welcome community contributions to any issue, but these might be a good place to start! and removed help-wanted labels Jun 28, 2019
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 2, 2019
@syncsiva syncsiva mentioned this issue Jan 13, 2020
Open
@LeoJHarris
Copy link

LeoJHarris commented Feb 5, 2020 •
edited
Loading

@samhouts Any chance this will be fixed any time soon?

@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Feb 6, 2020
@samhouts
Copy link
Member

There is an open PR for it, but I think we're still working on it. Thanks!

@LeoJHarris
Copy link

@samhouts thanks for the update! Hope it can be resolved soon that would be great!

@Mikilll94
Copy link

Any update on this?

@mackayn
Copy link

mackayn commented Jun 23, 2020

Just ran into this as well in 4.6.0 SR5

@jfversluis
Copy link
Member

Can't reproduce in 5.0.0 SR7 (5.0.0.2244), let me know if this is still an issue for someone!

@PlatypusJo
Copy link

I have this problem in 5.0.0.2622

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
excellent-report help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! p/Android p/iOS 🍎 p/UWP up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[All] Fix TextDecorations & DataTigger interaction alanag13/Xamarin.Forms
8 participants
@hartez @jfversluis @LeoJHarris @samhouts @davidbritch @mackayn @Mikilll94 @PlatypusJo