This repository has been archived by the owner on May 1, 2024. It is now read-only.
Remove WeekSubscribe extension method #1001
maxkoshevoi
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
To me it's ok to remove it. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As discovered in #987
WeekSubscribe
should never be used on week events. If it does, subscriber will get unsubscribed on first GC run.And since this repository also includes
ObservableObject
that usesWeekEventManager
, it makesWeekSubscribe
obsolete. Both do the same thing, and if used at the same time, user will get issue descried above.So, should it be removed, or should we add a check that subscriber cannot be
ObservableObject
?CC: @pictos, @brminnick, @jfversluis
Beta Was this translation helpful? Give feedback.
All reactions