This repository has been archived by the owner on May 1, 2024. It is now read-only.
Move effect bindable properties to different classes #1319
GalaxiaGuy
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
As I know, MAUI won't have Effects at all (Just behaviors with option of platform-specific implementation). |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This thought came about while I was deciding on what the ideal API would be for this feature suggestion:
#1280
The existing features define the bindable properties that are used by effects on the shared effect class itself, like here:
https://github.com/xamarin/XamarinCommunityToolkit/blob/main/src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/Semantic/SemanticEffect.shared.cs
This means consuming it through XAML looks like the following:
MAUI has things on other classes, for example
SemanticProperties
resulting in XAML like the following:My first approach, (without looking at existing implementations) was to name things entirely for easy of consumption, with XAML like the following:
The difference between the things in MAUI and the things in XCT is whether they are implemented in the core, or via an effect. Does the person consuming this care though? The effects generally have logic to auto-attach when you set the property, so having the
Effect
in the property name seems distracting.Also, it seems that the work in MAUI with handlers might mean that effects are not be needed to implement this kind of platform specific functionality in the future, and not having to update how the features are consumed would be nice.
(From a practical point of view I realise creating new classes with BPs and redirecting and deprecating the existing ones is not great).
Beta Was this translation helpful? Give feedback.
All reactions