Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated mode resource and tests. #55

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Updated mode resource and tests. #55

merged 2 commits into from
Mar 20, 2019

Conversation

glfejer
Copy link
Contributor

@glfejer glfejer commented Mar 19, 2019

fixes #38

@glfejer glfejer force-pushed the update-router-mode2 branch from 2b00d85 to 2809f86 Compare March 19, 2019 05:37
drbild
drbild suggested changes Mar 19, 2019
View reviewed changes
@glfejer glfejer force-pushed the update-router-mode2 branch from 2da5ac5 to bae1ae9 Compare March 19, 2019 17:45
drbild
drbild suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@drbild drbild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another round of comments, mostly on formatting of method doc strings.

@glfejer glfejer force-pushed the update-router-mode2 branch from daa15a5 to 90c5197 Compare March 19, 2019 21:08
drbild
drbild reviewed Mar 19, 2019
View reviewed changes
@drbild drbild merged commit 1cc138e into xaptum:master Mar 20, 2019
@drbild drbild deleted the update-router-mode2 branch March 20, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbild drbild drbild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

captived: Update router-mode resource to examine correct files
2 participants
@glfejer @drbild