Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-apply David's change - use secure instead of secure-host in json. #95

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Re-apply David's change - use secure instead of secure-host in json. #95

merged 1 commit into from
Aug 6, 2019

Conversation

glfejer
Copy link
Contributor

@glfejer glfejer commented Aug 6, 2019

fixes #94

@glfejer glfejer requested a review from drbild August 6, 2019 21:27
drbild
drbild approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@drbild drbild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glfejer glfejer merged commit 8c83c83 into xaptum:master Aug 6, 2019
@glfejer glfejer deleted the remove-secure-host branch August 6, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbild drbild drbild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

captived needs to use "secure" instead of "secure-host" in the JSON responses
2 participants
@glfejer @drbild