Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Playback fails when switching playback from one DRM type to another #1704

Closed
lavish440 opened this issue Oct 20, 2024 · 17 comments · Fixed by #1706
Closed

[Bug] Playback fails when switching playback from one DRM type to another #1704

lavish440 opened this issue Oct 20, 2024 · 17 comments · Fixed by #1706
Labels
Triage: Confirmed issue has been reproduced by a team member

Comments

@lavish440
Copy link

lavish440 commented Oct 20, 2024

Describe the problem

The playback fails when I switch from one DRM type let's say Widevine DASH to CK DASH or HLS.

Possible fix

Maybe it is caused due to the rework in Session property.

Steps to reproduce

  1. Play a DASH WDV stream
  2. Switch to a DASH CK stream while the previous one is still playing in the background

Debug log

2024-10-20 17:47:52.282 T:87615    info <general>: AddOnLog: inputstream.adaptive: Manifest successfully parsed (Periods: 1, Streams in first period: 3, Type: live)
2024-10-20 17:47:52.282 T:87615   error <general>: AddOnLog: inputstream.adaptive: InitializePeriod: Unhandled encrypted stream.

Stream manifest file(s)

No response

Additional info

I am not able to play any other type of stream than the one I started with unless I restart Kodi.

Operating system(s)

Linux

Operating system version(s)

Arch Linux

InputStream Adaptive version(s)

22.1.7 (Git Piers branch)

Kodi version(s)

22.0-ALPHA1 (21.90.700) Git:20241006-fcdd657039f-dirty

@lavish440 lavish440 added the Triage: Needed (managed by bot) issue that was just created and needs someone looking at it label Oct 20, 2024
@CastagnaIT CastagnaIT added Triage: Tested and not reproduced Effort has been placed into testing the issue but no one has been able to reproduce it yet and removed Triage: Needed (managed by bot) issue that was just created and needs someone looking at it labels Oct 20, 2024
@CastagnaIT
Copy link
Collaborator

CastagnaIT commented Oct 20, 2024

tested and to me works correctly
binary addons like this one works with single instance, two playbacks cant reuse same instance, so cant be in conflict

InitializePeriod: Unhandled encrypted stream.

more likely a bad configuration in DRM config or something unsupported in the manifest

@lavish440
Copy link
Author

tested and to me works correctly
binary addons like this one works with single instance, two playbacks cant reuse same instance, so cant be in conflict

Let me try with a new build from Kodi master

InitializePeriod: Unhandled encrypted stream.

more likely a bad configuration in DRM config or something unsupported in the manifest

The same config and manifest works after restarting Kodi.

@CastagnaIT
Copy link
Collaborator

Let me try with a new build from Kodi master

If you are doing the build yourself, also make sure to dont mix debug and release builds between kodi / ISA
mixing buld types can produce side effects

@lavish440
Copy link
Author

Let me try with a new build from Kodi master

If you are doing the build yourself, also make sure to dont mix debug and release builds between kodi / ISA
mixing buld types can produce side effects

Ohh, I will make sure of that.

@lavish440
Copy link
Author

lavish440 commented Oct 20, 2024

Not able to reproduce it on Android.
I can't test out the Kodi master on Arch Linux as it fails on some Groovy error for me.
I tried a lot of things but still it fails.

@CastagnaIT
Copy link
Collaborator

CastagnaIT commented Oct 21, 2024

i never used arch linux so idk,
if you attach the manifest and drm property config used (also censored) for the clearkey i can try understand the situation
also the full log with debug enabled, two lines of logs say little

@lavish440
Copy link
Author

i never used arch linux so idk,
if you attach the manifest and drm property config used (also censored) for the clearkey i can try understand the situation
also the full log with debug enabled, two lines of logs say little

I think this would be a very good usecase for the ISA Tester Python addon that you have developed.
I will try to use it.

@lavish440
Copy link
Author

I tested with your Py addon.

ISA.mp4

Wasn't able to get debug logs but one of the WDV License Server said:
403 License denied. The license request contains a key ID that is not present in the entitlement message: eb676abb-cb34-5e96-bbcf-616630f1a3da.

@CastagnaIT
Copy link
Collaborator

ok tested under ubuntu and i was able to replicate this situation
thats weird thing under windows dont happens
i will need to to some more tests

@CastagnaIT CastagnaIT added Triage: Confirmed issue has been reproduced by a team member and removed Triage: Tested and not reproduced Effort has been placed into testing the issue but no one has been able to reproduce it yet labels Oct 22, 2024
@lavish440
Copy link
Author

ok tested under ubuntu and i was able to replicate this situation
thats weird thing under windows dont happens
i will need to to some more tests

Looks like a Linux only issue then.
I will also try to reproduce it on Android if I can.

@CastagnaIT
Copy link
Collaborator

i opened a fix PR #1706
a test under ubuntu seem to works
try build ISA with it and let me know

@lavish440
Copy link
Author

Tested and looks like it has been fixed with the changes that you made.

@lavish440
Copy link
Author

@CastagnaIT Can you merge it please?

@CastagnaIT
Copy link
Collaborator

i was waiting review form someone of team but seem no one has time
i will merge anyway

@lavish440
Copy link
Author

I have tested it if it counts 😛

@CastagnaIT
Copy link
Collaborator

was not only for test it, but to know about correctness of the code change

@lavish440
Copy link
Author

Ohh got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Confirmed issue has been reproduced by a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants