-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA does not expose playback errors using onPlayBackError() #497
Comments
i have investigated on this problem, because i have similar problem on netflix the results are that ISA provide the right value to Kodi when going in error then the problem is not in ISA, i built a Kodi W64 build, from a first test with netflix Monitor seem now works, please test with your VRT addon: if go well i will try to do a PR |
@CastagnaIT This is an important one indeed, it would be nice to see this fixed in Matrix. We may have to discuss the best interface for add-ons in this case.
It would be nice to look at all the use-cases to ensure that our design is the most convenient for add-on developers. Maybe I am a bit over-concerned here, but I am very sensitive to consider all use-cases and at least try to have the best design from the very start. |
what are you referring to? |
You have different kinds of errors, and they have different information they can return, and we should have a good idea of the range of errors and the type of information that is returned, and how add-ons would be interacting with it. Look at the description of the issue and two specific use-cases we have. Maybe there are more? |
Ah your idea is would return a code and/or description of the error in the onPlayBackError() notification
could be useful, but not easy to implement, this could means add this support only for InputStream case, modify the IA interface to allow pass the error code from ISA to Kodi core Another problem is handle the streams errors, that could happen when while watching a video, currently are not good managed. |
I don't know what the best way forward is to capture all of the possible errors, but we do need some of those details to act upon. We already discussed it once briefly (which is why I opened this ticket here). |
We have a new use-case for better onPlayBackError() support from inputstream.adaptive: emilsvennesson/script.module.inputstreamhelper#441 (comment) If ISA can escalate issues loading the Widevine CDM, ISH can act on this and provide a solution, this would avoid any ugly workarounds to detect an incompatibility between Kodi and Widevine CDM. Other use-cases:
|
This is an important problem for many add-ons, if playing a stream fails by IA for whatever reason (authentication issue, license issue, any HTTP issue, format error or Widevine library issue) this is not reported back to the add-on. As a result an add-on cannot report this failure properly to the user, or implement a work-around (in case this is a known/expected issue). add-ons/plugin.video.vrt.nu#727
ISH (InputStream Helper) could use specific license or Widevine issues as an event for e.g. updating the Widevine library, and therefore would not need to check for newer Widevine libraries on every call (or after some TTL has expired). This would be a much better user experience. emilsvennesson/script.module.inputstreamhelper#69)
The text was updated successfully, but these errors were encountered: