Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag official releases #200

Open
alanbchristie opened this issue Sep 21, 2020 · 0 comments
Open

Tag official releases #200

alanbchristie opened this issue Sep 21, 2020 · 0 comments

Comments

@alanbchristie
Copy link
Collaborator

The frontend code is cloned into the stack image as it is built but there are no tags in the frontend repo to allow older builds of the stack to be created.

Rather than use "master" as a FE_BRANCH value the stack's Dockerfile should probably use an official tag, i.e. ARG FE_GIT_PROJECT_BRANCH="1.0.0" so that unexpected frontend behaviour changes won't disrupt past or future stack builds.

Currently, if you introduce a new frontend feature/behaviour change - and you re-build an older stack - then the stack you build may contain unexpected features or behaviour.

Recommended pattern:

When a stable frontend is available...

  1. Create a GitHub tag (or release) in the frontend repo (like 1.0.0)
  2. Update the stack repo's Dockerfile and replace the FE_BRANCH value with tags/1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant