create_vdi: make vdi name optional

Signed-off-by: Gaëtan Lehmann <[email protected]>

Author: glehmann

lib/common.py

@@ -7,6 +7,8 @@
 import itertools
 import logging
 import os
+import random
+import string
 import sys
 import time
 import traceback
@@ -233,6 +235,14 @@ def url_download(url: str, filename: str) -> None:
             fd.write(chunk)
     os.rename(tempfilename, filename)
 
+def randid(length=6):
+    """
+    Generates a random string of a specified length.
+    The string consists of lowercase letters, uppercase letters, and digits.
+    """
+    characters = string.ascii_lowercase + string.digits
+    return ''.join(random.choices(characters, k=length))
+
 @overload
 def _param_get(host: 'lib.host.Host', xe_prefix: str, uuid: str, param_name: str, key: Optional[str] = ...,
                accept_unknown_key: Literal[False] = ...) -> str:

lib/sr.py

@@ -4,6 +4,7 @@
 import lib.commands as commands
 from lib.common import (
     prefix_object_name,
+    randid,
     safe_split,
     strtobool,
     wait_for,
@@ -166,7 +167,10 @@ def get_type(self) -> str:
             self._type = self.pool.master.xe("sr-param-get", {"uuid": self.uuid, "param-name": "type"})
         return self._type
 
-    def create_vdi(self, name_label: str, virtual_size: int | str = '1GiB', image_format: Optional[str] = None) -> VDI:
+    def create_vdi(
+        self, name_label: str | None = None, virtual_size: int | str = '1GiB', image_format: Optional[str] = None
+    ) -> VDI:
+        name_label = name_label or f'test-vdi-{randid()}'
         logging.info("Create VDI %r on SR %s", name_label, self.uuid)
         args = {
             'name-label': prefix_object_name(name_label),