Add integrity check in live migration tests

Signed-off-by: Gaëtan Lehmann <[email protected]>

Author: glehmann

tests/storage/storage.py

@@ -1,16 +1,15 @@
+from __future__ import annotations
+
 import logging
 
 from lib.commands import SSHCommandFailed
-from lib.common import strtobool, wait_for, wait_for_not
+from lib.common import GiB, strtobool, wait_for, wait_for_not
+from lib.host import Host
 from lib.sr import SR
 from lib.vdi import VDI
+from lib.vm import VM
 
-from typing import TYPE_CHECKING, Literal
-
-if TYPE_CHECKING:
-    from lib.host import Host
-    from lib.vm import VM
-
+from typing import Literal
 
 def try_to_create_sr_with_missing_device(sr_type, label, host):
     try:
@@ -42,21 +41,51 @@ def cold_migration_then_come_back(vm, prov_host, dest_host, dest_sr):
     vm.wait_for_os_booted()
     vm.shutdown(verify=True)
 
-def live_storage_migration_then_come_back(vm, prov_host, dest_host, dest_sr):
+    if vdi_name is not None:
+        vm.destroy_vdi_by_name(vdi_name)
+
+def live_storage_migration_then_come_back(vm: VM, prov_host: Host, dest_host: Host, dest_sr: SR):
     prov_sr = vm.get_sr()
+    vdi_name = None
+
+    if not vm.is_windows:
+        vdi = prov_sr.create_vdi(virtual_size=1 * GiB)
+        vdi_name = vdi.name()
+        vm.connect_vdi(vdi, 'xvdb')
+
     # start VM
     vm.start(on=prov_host.uuid)
-    vm.wait_for_os_booted()
+    if vm.is_windows:
+        vm.wait_for_os_booted()
+    else:
+        vm.wait_for_vm_running_and_ssh_up()
+        install_randstream(vm)
+        logging.info("Generate /dev/xvdb content")
+        vm.ssh("randstream generate -v /dev/xvdb")
+        logging.info("Validate /dev/xvdb")
+        vm.ssh("randstream validate -v --expected-checksum 65280014 /dev/xvdb")
+
     # Move the VM to another host of the pool
     vm.migrate(dest_host, dest_sr)
     wait_for(lambda: vm.all_vdis_on_sr(dest_sr), "Wait for all VDIs on destination SR")
     wait_for(lambda: vm.is_running_on_host(dest_host), "Wait for VM to be running on destination host")
+    if not vm.is_windows:
+        logging.info("Validate /dev/xvdb")
+        vm.ssh("randstream validate -v --expected-checksum 65280014 /dev/xvdb")
+
     # Migrate it back to the provenance SR
     vm.migrate(prov_host, prov_sr)
     wait_for(lambda: vm.all_vdis_on_sr(prov_sr), "Wait for all VDIs back on provenance SR")
     wait_for(lambda: vm.is_running_on_host(prov_host), "Wait for VM to be running on provenance host")
+    if not vm.is_windows:
+        logging.info("Validate /dev/xvdb")
+        vm.ssh("randstream validate -v --expected-checksum 65280014 /dev/xvdb")
+
     vm.shutdown(verify=True)
 
+    if vdi_name is not None:
+        vm.destroy_vdi_by_name(vdi_name)
+
 def vdi_is_open(vdi):
     sr = vdi.sr