Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVM: set archive=1 in /etc/lvm/lvm.conf #619

Open
DSJ2 opened this issue Aug 28, 2023 · 5 comments
Open

LVM: set archive=1 in /etc/lvm/lvm.conf #619

DSJ2 opened this issue Aug 28, 2023 · 5 comments

Comments

@DSJ2
Copy link

DSJ2 commented Aug 28, 2023

From /etc/lvm/lvm.conf:

backup {
        # Configuration option backup/archive.
        # Maintain an archive of old metadata configurations.
        # Think very hard before turning this off. 
        archive = 0

think very hard before turning this off
Why is archive off in xcp-ng?

@stormi
Copy link
Member

stormi commented Aug 28, 2023

This comes from XenServer's packaging of lvm. It's explicitly disabled with:

sed -i 's/archive = .*/archive = 0/' $RPM_BUILD_ROOT/%{_sysconfdir}/lvm/lvm.conf

So there is a reason, but I don't see any comments or changelog entries which explains why, and there is no public repository whose history we could look at.

There is no XenServer public bugtracker for these package sources, but you may try to reach the main people involved in this decision on the repository for Storage Manager: https://github.com/xapi-project/sm/issues

@stormi
Copy link
Member

stormi commented Aug 28, 2023

Also CCing @Wescoeur in case he knows something I don't.

@Wescoeur
Copy link
Member

I don't know what the real reason for this change is, but it may prevent rollback to a specific position to ensure there is no problem on the sm side (e.g. LVHDSR).

@DSJ2
Copy link
Author

DSJ2 commented Aug 28, 2023

Opened xapi-project/sm#635

@MarkSymsCtx
Copy link

It's actually disabled by Redhat in the upstream packaging, XenServer (and then xcp-ng as a downstream of XenServer) just inherits that setting. If xcp-ng want to apply a different value they are more than welcome to rebuild the package to their own requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants