Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework FreeBSD detection to use /etc/os-release + add testcases #10

Open
stormi opened this issue May 10, 2021 · 2 comments
Open

Rework FreeBSD detection to use /etc/os-release + add testcases #10

stormi opened this issue May 10, 2021 · 2 comments

Comments

@stormi
Copy link
Member

stormi commented May 10, 2021

Following #1, I'd like us to consider parsing or evaluating /etc/os-release rather than relying on the output of uname. This would also allow to add testcases to mk/testcases and then to contribute the detection of FreeBSD upstream.

This is about xe-linux-distribution only, not install.sh.

CCing @pacohope.

@pacohope
Copy link

That's a fine idea, and I'd be happy to do it. But if you look at the FreeBSD source it looks like os-release is a pretty new mechanism. I'm struggling to read the version history in SVN, but it looks like this was created around the time of 12.2-RELEASE. So if we drop uname support, I think we will lose support for some older versions (e.g., 11.X) that are presently supported. I like /etc/os-release as a primary, first choice mechanism, though.

@stormi
Copy link
Member Author

stormi commented May 11, 2021

I agree with you, we should test for/etc/os-release first, then fallback to uname if not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants