Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new flag '--stdin-post-extract' for post-install commands #17

Open
toluschr opened this issue Jun 18, 2024 · 7 comments
Open

Use new flag '--stdin-post-extract' for post-install commands #17

toluschr opened this issue Jun 18, 2024 · 7 comments

Comments

@toluschr
Copy link
Contributor

xdeb-org/xdeb@f8d1b58 added a new flag '--stdin-post-extract'. If specified, xdeb executes commands from stdin right after fixing conflicts. This could be helpful in combination with xdeb-install's post-install option.

@thetredev
Copy link
Collaborator

Thanks for the heads up!

Unfortunately my "let's try Arch again" senses kicked in - I just had to try out KDE 6.0 on real hardware lol.

And now I ended up on Linux Mint LMDE of all things.

But development shouldn't be affected by it because of the devcontainer I've setup. It doesn't reflect a complete Void setup but I don't think this is gonna be a problem.

@thetredev
Copy link
Collaborator

Hmmm.. maybe I should allow the user to pass every argument to xdeb, like so:

$ xdeb-install <xdeb-install options/flags> -- <xdeb args>

@toluschr what do you think? Currently xdeb-install is kinda forcing some basic arguments to xdeb and that's it.

@toluschr
Copy link
Contributor Author

Would that require xdeb-install to parse the xdeb arguments? What about using environment variables to configure xdeb?

@thetredev
Copy link
Collaborator

No it would just take everything after -- and pass it to xdeb as is. xdeb-install won't do any checking whatsoever and will just print xdeb's output to stdout/stderr.

For environment variables we could just pass all environment variables we have onto xdeb as well.

I think we should separate the focus of each project. If we start verifying xdeb args from within xdeb-install, we could lose track updating both projects with stuff only one needs.

So I vote for giving xdeb all we get.

@toluschr
Copy link
Contributor Author

I agree with you on argument parsing. Can the user break xdeb-install by passing incorrect arguments to xdeb?

@thetredev
Copy link
Collaborator

I don't think so. Everything after -- is ignored by xdeb-install. I guess there's some shell magic you can hack together to break any tool via stdin but that's a thing the shell developers have to deal with I assume.

@thetredev
Copy link
Collaborator

@toluschr bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants