Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info and links in README.md #1

Open
juliancwirko opened this issue Dec 10, 2022 · 8 comments
Open

Info and links in README.md #1

juliancwirko opened this issue Dec 10, 2022 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@juliancwirko
Copy link
Member

Hey @ilyich-erd, great work on the Tailwind version! It would be good to adjust the README.md file to be more accurate for this version. It would also be good to deploy the tailwind version to netlify or vercel and replace the current demo link. That would be less confusing for developers who want to use it and don't know about the Chakra version, which is deployed here: https://multiversx-nextjs-dapp.netlify.app/ Thanks!

@juliancwirko juliancwirko added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 10, 2022
@ilyich-erd
Copy link
Collaborator

Perfect, I'll do it tomorrow. Do you have an xdevguild instance or should i use my own?

@juliancwirko
Copy link
Member Author

If you can, you can use your own. I also used my own. I can also deploy it using my instance if needed. Please let me know if you will have any questions.

@ilyich-erd
Copy link
Collaborator

I'll use my vercel instance. I'll open a pr so you can check the changes. I also notices some issues in the mobile version that will be fixed with tomorrow PR

@ilyich-erd
Copy link
Collaborator

Damn, I forgot that vercel makes you pay if you want to deploy from an org. I'll deploy on Netlify asap

@juliancwirko
Copy link
Member Author

Good to know ;)

@ilyich-erd
Copy link
Collaborator

Alright, i'm deploying now on Netlify, do you think that something else than changing the url on the readme should be done?

@juliancwirko
Copy link
Member Author

When it comes to the README.md I think it would be good to indicate that it is a Tailwind version. Besides that, I think the docs are the same.

@ilyich-erd
Copy link
Collaborator

#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants