New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyright: Update from 1.345 #2791

Open

3 tasks

AntonLydike opened this issue Jun 27, 2024 · 1 comment

Assignees

Labels

Collaborator

AntonLydike commented Jun 27, 2024 •

edited by superlopuh

Loading

We need to update pyright to a newer version (maybe BasedPyright).

There are a number of things that need to be fixed for this to happen:

Change the API for ConstraintVars, Annotated[Attribute, ConstraintVar("T")] is technically not valid for Python typing purposes
Either wait until the TypeExpr proposal to land or use a different technique (I have a WIP branch that annotates constraints with the types of attributes they accept, which gets us quite far in terms of reducing errors)
A number of unrelated issues that have accumulated as Pyright has evolved since 1.345

The text was updated successfully, but these errors were encountered:

AntonLydike added the dependencies label

superlopuh self-assigned this

Member

superlopuh commented Jun 27, 2024

I've started working on this, will try to merge some things bit by bit to get us closer. I'll update the Task description with progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment