Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scf.for implicit terminators #3325

Open
alexarice opened this issue Oct 18, 2024 · 3 comments
Open

scf.for implicit terminators #3325

alexarice opened this issue Oct 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@alexarice
Copy link
Collaborator

The implicit terminator infrastructure for scf.for does not seem to work correctly at the moment. See #3303

@alexarice alexarice added the bug Something isn't working label Oct 18, 2024
@compor compor self-assigned this Oct 23, 2024
@compor
Copy link
Collaborator

compor commented Oct 23, 2024

@alexarice This is now done, right? I didn't dig deeper but seems the (unrelated) issue that #3303 was trying to solve with printing unregistered ops. If so, close this or please elaborate with a MWE and I'll get around to it.

@alexarice
Copy link
Collaborator Author

%0 = arith.constant 0 : index
scf.for %iv = %0 to %0 step %0 {
  "unregistered"() : () -> ()
}

I would expect this to verify

@alexarice
Copy link
Collaborator Author

For comparison this is ok:

%0 = arith.constant 0 : index
scf.for %iv = %0 to %0 step %0 {
  "test.op"() : () -> ()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants