Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsys: coverage: fix arm64 build with gcov enabled #114

Closed

Conversation

GrygiriiS
Copy link

On ARM64 the build will fail with coverage and GCOV enabled:

CONFIG_COVERAGE=y
CONFIG_COVERAGE_GCOV=y
CONFIG_FORCE_COVERAGE=y

west build -b rcar_spider_ca55 -p always zephyr-dom0-xt
-S xen_dom0 -- -DCONFIG_COVERAGE=y -DCONFIG_FORCE_COVERAGE=y

Failure:
"linker_zephyr_pre0.cmd:181: undefined symbol `__gcov_bss_end' referenced
in expression"

Fix build of ARM64 platforms with coverage and GCOV enabled.

On ARM64 the build will fail with coverage and GCOV enabled:

  CONFIG_COVERAGE=y
  CONFIG_COVERAGE_GCOV=y
  CONFIG_FORCE_COVERAGE=y

 west build -b rcar_spider_ca55 -p always zephyr-dom0-xt \
 -S xen_dom0  -- -DCONFIG_COVERAGE=y -DCONFIG_FORCE_COVERAGE=y

Failure:
 "linker_zephyr_pre0.cmd:181: undefined symbol `__gcov_bss_end' referenced
in expression"

Fix build of ARM64 platforms with coverage and GCOV enabled.

Signed-off-by: Grygorii Strashko <[email protected]>
Copy link
Collaborator

@lorc lorc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Volodymyr Babchuk <[email protected]>

This one is also good candidate for upstreaming

Copy link
Collaborator

@firscity firscity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Dmytro Firsov <[email protected]>

@GrygiriiS GrygiriiS changed the base branch from zephyr-v3.6.0-xt to rpi5_dev June 18, 2024 07:37
@GrygiriiS GrygiriiS changed the base branch from rpi5_dev to zephyr-v3.6.0-xt June 18, 2024 07:38
@GrygiriiS GrygiriiS closed this Jun 18, 2024
@GrygiriiS
Copy link
Author

Will redo for rpi5_dev

@firscity
Copy link
Collaborator

firscity commented Jun 18, 2024

Are you sure, that this change is not needed for zephyr-v3.6.0-xt as well? I think it should go in all branches - Zephyr upstream main, zephyr-v3.6.0-xt and rpi5_dev

@GrygiriiS
Copy link
Author

Are you sure, that this change is not needed for zephyr-v3.6.0-xt as well? I think it should go in all branches - Zephyr upstream main, zephyr-v3.6.0-xt and rpi5_dev

Until we move to v3.6.0 and get rid of rpi5 branches I'd prefer to have patches merged in rpi5 branches firts and then ported to v3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants