Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin naming in JAR/POM #144

Open
rincerwind opened this issue Nov 5, 2018 · 3 comments
Open

Plugin naming in JAR/POM #144

rincerwind opened this issue Nov 5, 2018 · 3 comments

Comments

@rincerwind
Copy link

Hello,

Very nice plugin! However, I was wondering, given that the plugin is following the GAV format, shouldn't JARs and POMs both have Scala and SBT versions included in the name? What I mean is:

For the below GAV

GroupId: org.xerial.sbt
ArtifactId: sbt-pack_2.12_1.0
Version: 0.11

Shouldn't the path be /org/xerial/sbt/sbt-pack_2.12_1.0/sbt-pack_2.12_1.0-0.11.jar
Instead of /org/xerial/sbt/sbt-pack_2.12_1.0/sbt-pack-0.11.jar

I was looking at some other libraries as examples and they seem to include scala/sbt versions in the jar/pom. E.g the akka-actor library:

http://central.maven.org/maven2/com/typesafe/akka/akka-actor_2.12/2.5.17/

I might be wrong but I think a Nexus mirror with only Maven dependency resolution might not be able to resolve the plugin.

Thanks

@xerial
Copy link
Owner

xerial commented Nov 6, 2018

As you mentioned, sbt-pack is released in this path:
https://oss.sonatype.org/content/repositories/releases/org/xerial/sbt/sbt-pack_2.12_1.0/0.11/

But this suffix _1.0 is actually an sbt version, and it's sbt's requirement. So I can't change this path for now.

@rincerwind
Copy link
Author

Oh, sorry, maybe I didn't explain it properly. What I meant is that I think that the full artifactId should be included in the filenames - for artifactId 'sbt-pack_2.12_1.0' files should be 'sbt-pack_2.12_1.0-0.11.jar' (same for pom). The example I gave with akka doesn't include the sbt version for some reason but includes the full artifactId in the filename.

@xerial
Copy link
Owner

xerial commented Nov 8, 2018

@rincerwind That jar file naming is sbt's standard, so I think https://github.com/sbt/sbt is the right place to talk about such naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants