-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Norwell History Tools Visual Bugs in Firefox 115.0.3 #268
Comments
you can try it |
How did you find this file? I can't find it anywhere on the repository page. Anyway, I installed it, and while it does seem to fix the first issue (column sizes), I also edited the original post again to include a third bug (forgot to add earlier) that has not been addressed. |
This is serious, I went to my slut, get it as payment, it seems that he miscalculated.... |
Uh, are you ok? |
That's his own upload in this issue, it's not anywhere on the repo since it wasn't made by @xiaoxiaoflood.
Here's a slightly modified version that fixes squished date picker (from/to), and replaces removed norvel_history-3.1.0.2.2.109.2023.09.14-xiao.xpi.zip Calendar not working (poping out just for a second and closing) from what i remember is caused by [2023-24-10] There's most likely a better way of doing it, but that's beyond me, and this works without any issues for me. Though maybe it broke in other places because of that, but i literally never seen calendar popout in Firefox outside of norwell extension, so i couldn't even check that 🤷 If you want to try it, then unzip the .js file to:
and override it in
Maybe someone else will come up with a better way of fixing this, but for now this works on ESR115 without any visible issues. |
I didn't even notice the squished date picker. Thanks for pointing that out, but the version you sent didn't fix this for me, but
Where is |
Works on my side(Firefox 115.3.1esr), even on a clean profile with just scriptloader:
Somewhere between ESR102 and ESR115 I'm not sure how you're applying those changes (manually or removing the .zip extension and dragging
#limits {
position: fixed;
}
input[type="date"] {
- min-width: initial;
+ min-width: fit-content;
} This fixes squished date picker.
clearspan();
createspan(hData[i][1],1,rest);
hData[i][2]?createspan(hData[i][2],0,rest):createspan('',0,rest);
return;
}
- if (num == 3){ return (tree.view.selection.count>1)? alert("more than one row selected"): (!hData[tree.currentIndex][0])? alert("Last visit time is missing."): openUILinkIn( 'chrome://norwell/content/norwell.xhtml?a='+hData[tree.currentIndex][0], 'tab', {allowThirdPartyFixup: false, triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()} );}
+ if (num == 3){ return (tree.view.selection.count>1)? alert("more than one row selected"): (!hData[tree.currentIndex][0])? alert("Last visit time is missing."): openTrustedLinkIn( 'chrome://norwell/content/norwell.xhtml?a='+hData[tree.currentIndex][0], 'tab', {allowThirdPartyFixup: false, triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()} );}
if (num == 4)
{ And this one as mentioned above fixes
That would require another edit in - button.setAttribute("style","-moz-user-select:text;"+(z?"background-color:yellow;":""));
+ button.setAttribute("style","-moz-user-select:text;"+(z?"background-color:#1e1e1e;color:#00adee":""));
That's an internal Firefox file, you won't find it anywhere to replace it by hand, that's why it's needed to override it using the mentioned
Those paths refer to chrome folder located in Firefox profile, you'll need to create resources folder yourself, and chrome.manifest is already there since you wouldn't be able to use extensions without the loader installed. |
hello Sneakpeakcss, use |
You mean to do it from extension itself ? I wanted to avoid packaging and overriding from there just in case something goes wrong, since at that point it requires to turn off the whole extension to revert back in comparison to removing it from It would be nice to be able to do it only for Norwell rather than globaly, but i'm not even sure if that's possible here. If anyone doesn't want to bother with any downloading/editing, then here's a 'all-in-one' version, also including the change for yellow highligh. Just bear in mind all of the above: |
I had to restart my browser. Now it works.
Sorry, I misread what you wrote. I thought you meant that
I didn't modify anything yet, but do I just un-zip the extension, modify the .js files and re-zip it? I have also discovered yet another issue: Version from repository. Yours and dimdamin's version. Both pictures use the same history entries. The last three were links I clicked from the first site (https://ublockorigin.com/); I selected the first entry and used |
You might need to package it without any compression as a zip(?), i'm not certain, but you can find a manual for Firefox extensions provided by Mozilla somewhere. I just drop files over opened package in 7zip to overwrite them, so i don't have to bother packaging the whole thing over and over.
The highlights aren't working properly because of
You can always unpack edited and original extensions and compare them with something like WinMerge. Here's a 'clean' version that requires to manually apply CalendarFix: [2023-24-10] [2023-25-10] And here's one that has [2023-25-10] Both of them apply all of the previously mentioned fixes +
Works on both Firefox |
Just to be clear, this still applies globally, like mentioned here, and not only to the extension itself? Also, is there a way to fix this?
I assume not since this seems to be a consequence of how Firefox stores history, but it's annoying enough for me to ask about it. |
Yes, as long as Norwell extension is turned on, then it overrides the default While the changes to that file are minimal, and the calendar popout itself is so obscure that it's hard to find examples that use it, i would still recommend using the clean version and overriding that file manually. There's always a chance that it will be changed by Firefox update and require additional updates, and at that point it's more reasonable to keep it separate. Also it seems that even while using the edited
This sounds like something that would require changes to Firefox files that even scriptLoader doesn't have access to. Also i've updated links in previous post with updated versions that have some additional positioning fixes in extension, and changed the CalendarFix to avoid some errors in console. |
@Sneakpeakcss In regards to you updating links:
What are the differences between the top two? |
Same as mentioned previously. So there's no comparison between the top two files, they contain completely different things. All the links were gathered in one spot for convenience when i was updating them, and at this point, the extension is back to its previous state with some annoyances fixed on top of that. |
The extension does not remember the state of different columns when resizing them (Name, Location, Time, etc.)
Resized columns:
Refreshing or re-opening the extension changes the column width back to default:
Using the "Limits" button also brings up a bugged interface
Current installation on Firefox 115.0.3:
How it appears on my old LibreWolf installation:
"Open this time" option does not function when viewing search results
Clicking this option does nothing:
The text was updated successfully, but these errors were encountered: