Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch Windows release build to CMake + vcpkg #1650

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Jul 7, 2024

Sample release: https://github.com/shenlebantongying/goldendict-ng/releases

related #555
related #1503
related goldendict/goldendict#1428

Compared to the previous qmake-windows-release:

  • windows-2022 runner
  • use PowerShell and avoid bash/cmd
  • simply uses gh release for packages uploading
  • .7z & NSIS installer via CPack

Various details

  • vcpkg utilizes GitHub caches, initial build cost around 35 mins, subsequent builds cost ignorable time
  • build time reduced from qmake+nmake -> 7.5mins to cmake+ninja -> 5mins.

Known issues:

  • For some reason, CPack cost super long time to compress the files

@shenlebantongying shenlebantongying marked this pull request as draft July 7, 2024 16:43
@shenlebantongying shenlebantongying marked this pull request as ready for review July 7, 2024 20:43
@shenlebantongying shenlebantongying changed the title feat: CMake + Vcpkg release build feat: CMake + Vcpkg release build (replace qmake build) Jul 7, 2024
@shenlebantongying shenlebantongying marked this pull request as draft July 8, 2024 03:23
@shenlebantongying shenlebantongying marked this pull request as ready for review July 8, 2024 03:53
@shenlebantongying shenlebantongying changed the title feat: CMake + Vcpkg release build (replace qmake build) feat: switch Windows release build to CMake + vcpkg Jul 8, 2024
@xiaoyifang
Copy link
Owner

you can merge this when finished.

@shenlebantongying shenlebantongying force-pushed the staged branch 2 times, most recently from 26cbbf0 to 0b3008b Compare July 8, 2024 16:22
@shenlebantongying shenlebantongying merged commit 61e1be9 into xiaoyifang:staged Jul 8, 2024
16 checks passed
Copy link

sonarqubecloud bot commented Jul 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants