-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove winlibs and use vcpkg instead #555
Comments
this can be postpone after cmake adaption which is qt6. |
vcpkg and cmake can be used together , |
ffmpeg needs hours to build 😅 😅 vcpkg has a experimental GitHub caches feature that uses GitHub caches. Maybe this feature does not work for now. We can also make a new workflow that dedicates to building a cache for all dependencies and drop them into the current winlibs. Personal free GitHub has 10 GiB space for caches. https://learn.microsoft.com/en-us/vcpkg/consume/binary-caching-github-actions-cache https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows Or we simply drop ffmpeg now. |
ffmpeg does not needed anymore when qt>6.5(?). or do not build with ffmpeg enabled on Windows |
TODO for future PRs
|
The vcpkg bundled in GitHub actions runners update every time the runner image updates. This means vcpkg packages will be updated weekly. Update frequency -> https://github.com/search?q=repo%3Aactions%2Frunner-images+Windows+Server+2022&type=pullrequests The initial full build needs maybe 30 mins. https://github.com/shenlebantongying/goldendict-ng/actions/runs/9824674216/job/27123911938 . I suppose that even if the vcpkg updates, the old caches are still useable if the library isn't updated? Worst case scenario: one super long build to create caches every week 😅 |
I consider this is finished. Let's just keep the winlibs just for now, just for PR check. |
Is your feature request related to a problem? Please describe.
Currently the packages in winlibs are mostly taken from vcpkg build packages.
Describe the solution you'd like
use vcpkg and qmake /cmake together .
Maybe need change the github action script at the same time.
Steps:
create a seperate repository to backup the winlibs https://github.com/xiaoyifang/goldendict-winlibs
remove eb.lib from winlibs and use submodule eb
use cmake to build qt6 based goldendict
integrete vcpkg with cmake
vcpkg has better support for cmake
new features will stop to add to qt5 if it cost extra work.
The text was updated successfully, but these errors were encountered: