Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI score greater than 1 #11

Closed
shanshenbing opened this issue Aug 11, 2020 · 7 comments
Closed

MSI score greater than 1 #11

shanshenbing opened this issue Aug 11, 2020 · 7 comments

Comments

@shanshenbing
Copy link

I ran MSIsensor-pro with paired samples successfully and I found some sample has a MSI score great than 1. Actually, the MSI score is the percent of somatic sites, which can not be 1 or great than 1. So, I am confused with the result. I hope you can give me some suggestions.
25X(X8GVQDO$8K8TFKZBNH0

@PengJia6
Copy link
Collaborator

I ran MSIsensor-pro with paired samples successfully and I found some sample has a MSI score great than 1. Actually, the MSI score is the percent of somatic sites, which can not be 1 or great than 1. So, I am confused with the result. I hope you can give me some suggestions.
25X(X8GVQDO$8K8TFKZBNH0

Could you please send your command and output to me. My email is [email protected]

Thanks !

@shanshenbing
Copy link
Author

Sorry,It‘s my fault. I didn't notice that MSIsensor-pro output is in percent and my data is just greater than 1%. And I also run msisensor with my data and I found the MSI scores of the same sample are different. Is this normal?

@PengJia6
Copy link
Collaborator

Sorry,It‘s my fault. I didn't notice that MSIsensor-pro output is in percent and my data is just greater than 1%. And I also run msisensor with my data and I found the MSI scores of the same sample are different. Is this normal?

This is normal, but I don't think it matters. This may caused by the different default parameters between these two programs.

@shanshenbing
Copy link
Author

shanshenbing commented Aug 17, 2020 via email

@PengJia6
Copy link
Collaborator

The result of first 35 samples is in the accessory, and I found the Pearson r is about 0.7 compulated with all my data.  The parameters are similar to each other, but results are different. And I also found a relate issue at ding-lab/msisensor#3

The msi module in msisensor-pro is inherited from msisensor, the results should be same. Could you please add -c option to the two command and try again, because there is a small bug in the default parameter, please see #8 .
Please let me know if this is workable and feel free to contact me if you have any question.

@shanshenbing
Copy link
Author

I wrote the last comment in QQ mailbox and the space character was converted into '  '. I am sorry for the confusing meaning. I checked msisensor default parameters and found the default -c in msisensor is 20, so msisensor-pro was run with -c 20. The result of the two software are same. Thank you for your help! Maybe the next release of msisensor-pro can change the default value of -c parameter.

@PengJia6
Copy link
Collaborator

@shanshenbing Thanks, I had updated source code and binary version, and conda version would be updated later. Thanks for using our software and give feedback, if you have other questions, please open a new issue or contact with me directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants