Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Plan for Spedoske before Jul 21 #237

Closed
2 of 3 tasks
Spedoske opened this issue Jul 15, 2023 · 4 comments
Closed
2 of 3 tasks

Action Plan for Spedoske before Jul 21 #237

Spedoske opened this issue Jul 15, 2023 · 4 comments
Assignees
Labels
In-progress The task is working in process at the moment

Comments

@Spedoske
Copy link
Collaborator

Spedoske commented Jul 15, 2023

Codebase cleanup

I was working on the clean up the project last week.

strimzi-kafka-cluster-operator

I used strimzi-kafka-cluster-operator to test if Acto could work. The task will be finished as long as the codebase cleanup is done.

Collect code coverage after running every test case

This can be achieved by

  • change the operator image
  • add a collect_coverage function in acto/runner/snapshot_collector.py
@Spedoske Spedoske added the In-progress The task is working in process at the moment label Jul 15, 2023
@Spedoske Spedoske self-assigned this Jul 15, 2023
@tianyin
Copy link
Member

tianyin commented Jul 16, 2023

@Spedoske Could you give an estimation on the codebase cleanup? When do you expect it to be done?

@tylergu
Copy link
Member

tylergu commented Jul 16, 2023

@Spedoske One thing which can help you is to break down these big tasks into small milestones and it would be much easier to plan and execute the actions and give an estimation.

@tianyin
Copy link
Member

tianyin commented Jul 16, 2023

yes exactly that will be super helpful for me.

I also feel uncomfortable for huge PRs.

I hope we do very small and incremental PRs.

@tianyin
Copy link
Member

tianyin commented Jul 23, 2023

This again is expired without updates or discussions, but I guess at this point I don't really care.

@tianyin tianyin closed this as completed Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-progress The task is working in process at the moment
Projects
None yet
Development

No branches or pull requests

3 participants