Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the sync_compaction_request implementation #371

Open
Phoenix500526 opened this issue Jul 11, 2023 · 0 comments
Open

Improve the sync_compaction_request implementation #371

Phoenix500526 opened this issue Jul 11, 2023 · 0 comments
Assignees
@Phoenix500526
Labels
Improvement Refactor or optimization, including process, performance or something like that

Comments

@Phoenix500526
Copy link
Collaborator

When a client compacts the specific revision with the physical option, the KvServer will block until the compactor finishes the compaction task. However, we place the block logic in sync_compaction_request currently. This is not a good practice in that it will block the state machine. We need to move it into the KvServer.
@Phoenix500526 Phoenix500526 self-assigned this Jul 11, 2023
@Phoenix500526 Phoenix500526 mentioned this issue Jul 11, 2023
Merged
@Phoenix500526 Phoenix500526 added the Improvement Refactor or optimization, including process, performance or something like that label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phoenix500526 Phoenix500526

Labels
Improvement Refactor or optimization, including process, performance or something like that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Phoenix500526