-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented 'pagerTabStripViewController:didMoveToIndex:' delegate method #53
Conversation
…alling 'moveToViewController:'
@michaelEllisUy Any chance that this PR will get accepted? If not, I need to fork the repository so that I can use it for my personal project. Thanks |
…into development Conflicts: XLPagerTabStrip/XL/Controllers/XLPagerTabStripViewController.m
@michaelEllisUy I've fixed the merge conflicts on this PR. Hoping to see this implemented soon? |
Just realized I've been tagging the wrong person when asking about the PR. Apparently @mtnbarreto is the author for this. Sorry. |
This PR has been brought up to date with @mtnbarreto Any chance that I can get a response on this PR? I'm using this in a production application right now and have to create and keep updated my own private version of the Pod is a drag. Thanks |
…into development Conflicts: XLPagerTabStrip/Demo/Storyboard.storyboard XLPagerTabStrip/XL/Views/XLButtonBarView.h XLPagerTabStrip/XL/Views/XLButtonBarView.m
55de98c
to
9e50728
Compare
I see that there have been a bunch of changes that have caused merge conflicts for this PR. I'd be happy to resolve the merge conflicts if you are interested in pulling this in still? Otherwise, feel free to let me know and close the request. |
I think this can be very useful |
How is this not part of this library? And this has 3400 stars.. ~ line 250 of PagerTabStripViewController.swift
Perhaps I will make my own pull request in a bit |
@AnthonyMDev thanks for contributing but the base code has changed too much to merge these changes. In addition to that i don't want to make the library more complex to use. |
This should close #38
EDIT:
willMoveToIndex:
has since been added.This has been tested thoroughly and works as expected on all view controllers.
I've realized that there really is no good way to implement a 'willMoveToIndex:' delegate method, because the scroll view will already have moved half-way to the other view controller in the case of the user dragging the scroll view.
This method is called after the scroll view has completed all scrolling animations to reach the new view controller.