Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE file installing in usr/LICENSE #284

Open
NGC2023 opened this issue Jun 9, 2024 · 0 comments
Open

LICENSE file installing in usr/LICENSE #284

NGC2023 opened this issue Jun 9, 2024 · 0 comments

Comments

@NGC2023
Copy link

NGC2023 commented Jun 9, 2024

Hi,
The LICENSE file installing in usr/LICENSE [0] in Debian. I have a patch to address it,

--- a/setup.py
+++ b/setup.py
@@ -27,7 +27,6 @@ setup(
     description = 'unittest-based test runner with Ant/JUnit like XML reporting.',
     long_description = long_description,
     long_description_content_type = 'text/markdown',
-    data_files = [('', ['LICENSE'])],
     install_requires = ['lxml'],
     license = 'BSD',
     platforms = ['Any'],

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068500
tpetazzoni added a commit to tpetazzoni/unittest-xml-reporting that referenced this issue Aug 17, 2024
@tpetazzoni
setup.py: drop data_files, installs LICENSE to incorrect place
662cd67 
As reported in issue
xmlrunner#284, the
data_files statement in the setup() calls installs the LICENSE file in
the wrong place: in /usr/LICENSE, or even /LICENSE depending on the
configuration.

So let's drop this, and let setuptools install the LICENSE file
automatically: since setuptools v56, the license_files attribute is
automatically assigned to a default value, which includes "LICENSE",
so there is in fact nothing to do to the get the LICENSE file
installed at the correct location. See
https://setuptools.pypa.io/en/latest/history.html#v56-0-0.

Signed-off-by: Thomas Petazzoni <[email protected]>
@tpetazzoni tpetazzoni mentioned this issue Aug 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NGC2023