Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@xmpp/connection disconnect - Cannot read properties of null (reading 'end') #1013

Open
filipw01 opened this issue Aug 9, 2024 · 1 comment

Comments

@filipw01
Copy link

filipw01 commented Aug 9, 2024

Describe the bug
Calling client?.disconnect it's possible that this.socket is undefined

Logs
I didn't get a chance to reproduce it locally. Only attaching sentry logs
Screenshot 2024-08-09 at 14 33 47

I suspect it could be a case when client is already disconnected but please let me know if I should provide more logs/reproduction

Environment
Browser

@sonnyp
Copy link
Member

sonnyp commented Dec 12, 2024

I agree it should throw if socket is undefined.

Can you send a PR?

async disconnect(timeout = this.timeout) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants