From c3af4dca0e67a408cb1e9896abbdae3a4843b3a7 Mon Sep 17 00:00:00 2001 From: Jennifer Hasegawa <5481259+jhaaaa@users.noreply.github.com> Date: Fri, 12 Apr 2024 17:06:03 -0700 Subject: [PATCH 1/2] inc feedback from Aurel/CAI --- XIPs/xip-21-transaction-reference-content-type.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/XIPs/xip-21-transaction-reference-content-type.md b/XIPs/xip-21-transaction-reference-content-type.md index c2cdef4..61a8a60 100644 --- a/XIPs/xip-21-transaction-reference-content-type.md +++ b/XIPs/xip-21-transaction-reference-content-type.md @@ -3,7 +3,7 @@ title: On-chain transaction reference content type description: Provides an on-chain transaction hash or ID sent as a message. author: @rygine (Ry Racherbaumer), @lourou (Louis Rouffineau), @nmalzieu (Noé Malzieu), @galligan (Matt Galligan), @nakajima (Pat Nakajima), @yash-luna (Yash Lunagaria) discussions-to: https://community.xmtp.org/t/xip-21-on-chain-transaction-reference-content-type/532 -status: Draft +status: Review type: Standards Track category: XRC created: 2024-01-26 @@ -35,9 +35,9 @@ The goal of the transaction reference content type is to provide transaction det ```ts type TransactionReference = { /** - * The namespace for the networkId + * The CAIP-2 chain ID where the transaction happened in the format `:` */ - namespace?: string; + chainId?: string; /** * The networkId for the transaction, in decimal or hexidecimal format */ @@ -45,7 +45,7 @@ type TransactionReference = { /** * The transaction hash */ - reference: string; + transactionHash: string; /** * Optional metadata object */ @@ -62,7 +62,7 @@ type TransactionReference = { ## Rationale -The `networkId` provides details of the network used for the transaction, while the `reference` field contains the hash of the transaction on the network. These two fields should be enough to display a basic reference to the transaction. An optional `namespace` field can be used for a more human-readable description of the network. +The `chainId` provides details of the network used for the transaction in [CAIP-2 format](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-2.md), while the `transactionHash` field contains the hash of the transaction on the network. These two fields should be enough to display a basic reference to the transaction. An optional `namespace` field can be used for a more human-readable description of the network. In addition, optional `metadata` can be added to provide more details and a richer display of the transaction. From 7243965e7e3bb5d2fea26f94236003d2d0f33be6 Mon Sep 17 00:00:00 2001 From: Jennifer Hasegawa <5481259+jhaaaa@users.noreply.github.com> Date: Wed, 17 Apr 2024 17:33:13 -0700 Subject: [PATCH 2/2] jha fix --- XIPs/xip-21-transaction-reference-content-type.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/XIPs/xip-21-transaction-reference-content-type.md b/XIPs/xip-21-transaction-reference-content-type.md index 61a8a60..57e24b1 100644 --- a/XIPs/xip-21-transaction-reference-content-type.md +++ b/XIPs/xip-21-transaction-reference-content-type.md @@ -38,10 +38,6 @@ type TransactionReference = { * The CAIP-2 chain ID where the transaction happened in the format `:` */ chainId?: string; - /** - * The networkId for the transaction, in decimal or hexidecimal format - */ - networkId: number | string; /** * The transaction hash */