Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Multi Wallet to just take 1 signature #1312

Closed
nplasterer opened this issue Nov 21, 2024 · 1 comment · Fixed by #1314
Closed

Update Multi Wallet to just take 1 signature #1312

nplasterer opened this issue Nov 21, 2024 · 1 comment · Fixed by #1314
Assignees
@codabrink
Labels
enhancement New feature or request

Comments

@nplasterer
Copy link
Contributor

Update the way multi wallet add account work to only need 1 signature.
@nplasterer nplasterer added the enhancement New feature or request label Nov 21, 2024
@neekolas
Copy link
Contributor

What we would need to do here is sign the signature request with the installation keys inside identity_updates.rs in the associate_wallet function, and add some tests to verify this all works as expected.

@nplasterer nplasterer moved this to In Progress in V3 Backlog Nov 21, 2024
@codabrink codabrink mentioned this issue Nov 22, 2024
Merged
@codabrink codabrink linked a pull request Nov 22, 2024 that will close this issue
Simplify Wallet Association By Using Installation Keys #1314
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in V3 Backlog Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codabrink codabrink

Labels
enhancement New feature or request
Projects
V3 Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify Wallet Association By Using Installation Keys xmtp/libxmtp
3 participants
@neekolas @codabrink @nplasterer