Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove NATS completely #367

Open
neekolas opened this issue Mar 28, 2024 · 0 comments
Open

Feature request: Remove NATS completely #367

neekolas opened this issue Mar 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@neekolas
Copy link
Collaborator

neekolas commented Mar 28, 2024

Is your feature request related to a problem?

We get very little value from Nats, and it makes our streaming setup more complicated. We should just get rid of it altogether.

Describe the solution to the problem

  1. Migrate MLS to use the same subscription dispatcher that api/v1 is using
  2. Remove dependency on nats from the subscription dispatcher and instead rely on messages being published directly on the dispatcher with some sort of new Dispatch function that takes in a proto.Envelope as an argument.
  3. Hook up the two HandleIncomingWakuRelayMessage functions to publish directly to the dispatcher without Nats

Describe the uses cases for the feature

No response

Additional details

As a bonus, this change will remove one round of serialization for every message received from Waku.

@neekolas neekolas added the enhancement New feature or request label Mar 28, 2024
@insipx insipx assigned insipx and unassigned insipx Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants