feat: Decoded Message Types #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved Decoded Message types and returns from listing Added DecodedMessageUnion utility type to manage returned values from list methods Added more type tests to help check against type usage
alexrisch
commented
Nov 28, 2024
| }, | ||
| { contentType: ContentTypeNumber } | ||
| } | ||
| // { contentType: ContentTypeNumber } |
There was a problem hiding this comment.
These were already failing, V3 related I believe
thierryskoda
approved these changes
Nov 28, 2024
| @@ -21,6 +21,7 @@ export enum MessageDeliveryStatus { | |||
| } | |||
|
|
|||
| export class DecodedMessage< | |||
| ContentType extends DefaultContentTypes[number] = DefaultContentTypes[number], | |||
There was a problem hiding this comment.
Maybe we could have a type for DefaultContentTypes[number] like
export type DefaultContentType = DefaultContentTypes[number]
since we use it a lot
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please enjoy this Thanksgiving Gif
Improved Decoded Message types and returns from listing
Added DecodedMessageUnion utility type to manage returned values from list methods
Added more type tests to help check against type usage
One callout is to really make types work I am using as const for the codecs, I did this rather than requiring readonly array of codecs. This means integrators can still dynamically create codecs but still use types, but this is only needed for the initial type inferencing if done by the client