Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relies on the pipes module, removed from the standard library in Python 3.13 #119

Open
musicinmybrain opened this issue Jun 12, 2024 · 0 comments · May be fixed by #120
Open

Relies on the pipes module, removed from the standard library in Python 3.13 #119

musicinmybrain opened this issue Jun 12, 2024 · 0 comments · May be fixed by #120

Comments

@musicinmybrain
Copy link

$ gh repo clone xolox/python-coloredlogs
$ cd python-coloredlogs
$ tox -e py312

(all tests pass)

$ tox -e py313
==================================================================================================== ERRORS ====================================================================================================
____________________________________________________________________________________ ERROR collecting coloredlogs/tests.py _____________________________________________________________________________________
ImportError while importing test module '/home/ben/src/forks/python-coloredlogs/coloredlogs/tests.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
coloredlogs/tests.py:22: in <module>
    from humanfriendly.testing import PatchedAttribute, PatchedItem, TestCase, retry
.tox/py313/lib/python3.13/site-packages/humanfriendly/testing.py:28: in <module>
    import pipes
E   ModuleNotFoundError: No module named 'pipes'
=========================================================================================== short test summary info ============================================================================================
ERROR coloredlogs/tests.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=============================================================================================== 1 error in 0.09s ===============================================================================================

I will follow up with a PR to replace pipes.quote with shlex.quote, as in xolox/python-humanfriendly#75. The shlex.quote() API is available from Python 3.3 on; pipes.quote() was never documented.

musicinmybrain added a commit to musicinmybrain/python-coloredlogs that referenced this issue Jun 12, 2024
The shlex.quote() API is available from Python 3.3 on; pipes.quote() was
never documented, and is removed in Python 3.13.

Fixes xolox#119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant