-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running RTD from Travis #129
Comments
Give |
Ok. First problem solved at https://travis-ci.org/CoinsManager/CoinsManager/builds/18246964 The problem is that the rtd script is trying to pwd from Running grunt with runOnce in local doesn't finish: But at least it doesn't watch for new changes in files. will try it in Travis after I get the first issue solved |
cp: cannot stat issue is because I didn't version the Bug when running grunt runOnce, jshint is executed even when disabled. Fixing it in a pull request |
add conditions to run jshint and coffeelint in grunt runOnce. Related to issue xolvio#129
add conditions to run jshint and coffeelint in grunt runOnce. Related to issue xolvio#129
Finally solved several issues of packages dependencies, and tests are run successfully on Travis. But as I feared before @treybean the build does not finish and is pending. Build can be seen here: https://travis-ci.org/CoinsManager/CoinsManager/builds/18313136 @samhatoum @Nomeasmo Seems to be a bug from #85 |
Temporary solution is to comment the task should be smarter and verify that sessions are open before trying to close them |
without the closeWebdriverSessions you would get orphan browsers. Do you experience this with Travis with the line commented out? |
Hi Sam, I do not use Travis, anyway runOnce now activated. Refer to the changes here: Nomeasmo@45e8132 Oliver Am 12.02.2014 um 03:39 schrieb Sam Hatoum [email protected]:
|
@samhatoum travis is smart enough to kill processes itself apparently, not seeing any problem. But in local, if I run @Nomeasmo can you do a pull request to RTD with your code ? Just modifying the files manually doesn't work for me (actually there isn't even a |
add conditions to run jshint and coffeelint in grunt runOnce. Related to issue xolvio#129
I rebased my code with rtd upstream (noticing that my PR #130 has been removed), and the problem is still there: When you start grunt runOnce, it will never finish. You need to ctrl-c to get back to the shell. |
Please refer to the pr #143 Let me know what you think about the limitation. |
@Nomeasmo thank you for the PR. I rebased from it, and it finally closed after a while, but on a failure: Finished in 0.004 seconds
|
@Fandekasp does this happen also in the meteor-rtd-example-project? When does this happen? |
Didn't check with meteor-rtd-example-project.
I didn't implement acceptance tests for CoinsManager yet, need to learn how to do them. Focusing on unit testing for the moment.
I don't think I'm using any driver if I don't have any acceptance tests :) |
When running only a few minimal unit tests, no acceptance tests and no coverage check, the grunt command doesn't fail.
Hence I tried to configure Travis, to run tests after each commit on github, as follow:
.travis.yml
:Makefile
.gitmodules
(replace git → https)But there are 2 problems:
From https://travis-ci.org/CoinsManager/CoinsManager/builds/18244442:
Because rtd is a ci tool in itself and never stops, the travis build will never finish. How can I specify RTD to run a single set of tests and quit ?
Thank you for your help. I'll set up a new module travis-rtd-meteor or something, to make it easier for other rtd users to integrate Travis as well.
The text was updated successfully, but these errors were encountered: