Support for samsung NP-Q1

[ekhaled]

lspci -nn

00:00.0 Host bridge [0600]: Intel Corporation Mobile 915GM/PM/GMS/910GML Express Processor to DRAM Controller [8086:2590] (rev 03)
 00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile 915GM/GMS/910GML Express Graphics Controller [8086:2592] (rev 03)
 00:02.1 Display controller [0380]: Intel Corporation Mobile 915GM/GMS/910GML Express Graphics Controller [8086:2792] (rev 03)
 00:1b.0 Audio device [0403]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) High Definition Audio Controller [8086:2668] (rev 03)
 00:1c.0 PCI bridge [0604]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) PCI Express Port 1 [8086:2660] (rev 03)
 00:1c.1 PCI bridge [0604]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) PCI Express Port 2 [8086:2662] (rev 03)
 00:1d.0 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) USB UHCI #1 [8086:2658] (rev 03)
 00:1d.1 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) USB UHCI #2 [8086:2659] (rev 03)
 00:1d.2 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) USB UHCI #3 [8086:265a] (rev 03)
 00:1d.7 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) USB2 EHCI Controller [8086:265c] (rev 03)
 00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge [8086:2448] (rev d3)
 00:1f.0 ISA bridge [0601]: Intel Corporation 82801FBM (ICH6M) LPC Interface Bridge [8086:2641] (rev 03)
 00:1f.1 IDE interface [0101]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) IDE Controller [8086:266f] (rev 03)
 00:1f.3 SMBus [0c05]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) SMBus Controller [8086:266a] (rev 03)
 02:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. 88E8036 PCI-E Fast Ethernet Controller [11ab:4351] (rev 14)
 03:00.0 Ethernet controller [0200]: Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)
 06:09.0 CardBus bridge [0607]: Ricoh Co Ltd RL5c475 [1180:0475] (rev 81)

dmidecode ....

SQ1S

[ekhaled]

I have made the following changes :ekhaled@cb11284 but they don't seem to work.

Is there anything else I can do to test apart from pressing the Fn+Up / Fn+Down keys?

It might be something to do with the wrong pci device id, how do I find that out?

Please help...

[xonatius]

Hello.
First of all you could try this:

setpci -s 00:02.0 f4.b=FF

where FF it's a hex number from 00 (backlight off) to FF (max lightness).

According to your lspci output your device id is 2592 (end of the second line). This id should be detected in samsung_init function (see lines 267-275). So you should just try to add lines:

        if (!pci_device)
                pci_device = pci_get_device(PCI_VENDOR_ID_INTEL, 0x2592, NULL);

before

        if (!pci_device)
                return -ENODEV;

Sorry for waiting.

[ekhaled]

First of all thanks for getting back to me,

I was trawling through here to find the pci device id, and was trying (unsuccessfully) with 2590. Never knew it was right here hiding in plain sight. n00b!!!

Any way, I compiled it and installed it (with the changes you suggested), but modinfo does not mention samsung-backlight, also dmesg | grep samsung does not return anything.

Now it might be something to do with another driver I installed earlier called samsung-laptop, I think it's from your other branch. Both the drivers .ko files sit in the same staging/samsung-laptop/ directory.

I tried to rmmod samsung-laptop and modprobe -d samsung-laptop, both of them don't seem to remove the driver.

So, I tried adding blacklist samasung-laptop in /etc/modprobe.d/blacklist.conf, again no change in dmesg or modinfo

I'm using Ubuntu 11.04, any ideas?

Is it going to cause any adverse effects if I deleted the samasung-laptop.ko manually?

BTW, setpci -s 00:02.0 f4.b=[00-FF] works. Does that mean the driver is somehow loaded? or is that supposed to work anyway?

Thanks a lot for your help...

[xonatius]

It's really strange that modinfo didn't find samsung-backlight. Looks like installation script works wrong in some situations. First of all you could try to load module from file by insmod samsung-backlight.ko in project directory. If it works, the problem is in installation script.
samsung-laptop - it's a module from default kernel package. I'm not sure, but it shouldn't clash with samsung-backlight. But any way you can try to move it in other place instead of deleting it.
setpci it's a direct call to the hardware address, it doesn't mean, that module works. Actually, backlight module doing only one thing - provide interface to setting backlight value to this address.
By the way, have you tried "easy slow down manager" or any other samsung-backlight packages?

Waiting for information (=

[ekhaled]

So sorry, I meant lsmod does not pick it up. modinfo picks it up fine.
I tried insmod from the source directory, but it says insmod: error inserting 'samsung-backlight.ko' : -1 No such device

Also I have already have acpi_backlight=vendor in GRUB.

I have never heard of easy slow down manager, but I will try it and get back to you.

Thanks for your help

[ekhaled]

Ok, just tried easy slow down manager, it's not listed in lsmod or dmesg and modprobe samsung-backlight still errors out with no such device

[ekhaled]

Right, sorry for the repeated comments,

I think I narrowed down the problem to the dmi device vendor string
Please have a look at ekhaled@3699fb3 for the changes I had to made.

I have removed the driver installed by easy slow down manager, but this driver does not load on boot.
But when I manually do modprobe samsung-backlight it loads and dmesg says found laptop model 'SQ1S'
And although the driver reports as being loaded, the keyboard Fn+UP & Fn+DOWN do not work.
Also pressing the those keys do not report any events in xev.
Is that a different problem?

[xonatius]

It's a quite interesting that laptop has another dmi vendor.
According to your dmesg log backlight module should work. You can check it by writing brightness level (from 0 to 7) to /sys/devices/pci0000:00/0000:00:02.0/backlight/samsung/brightness or by some system settings, widget.
About keyboard keys - it's really a different problem and I don't know what to do with it right now, but I'll try to find out solution.