Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyone having issues with the recent currentWindow: false change? A feedback needed. #5

Open
xpl opened this issue Aug 30, 2018 · 4 comments

Comments

@xpl
Copy link
Owner

xpl commented Aug 30, 2018

See this PR by @dmitry-pogorelov: #4

screen shot 2018-08-30 at 15 48 03

Some users (@acfasj) report that the parameter change does not work as expected... Unfortunately I currently do not have time to test & verify this thoroughly, so I would appreciate any feedback.

@oneezy
Copy link

oneezy commented Sep 16, 2018

I can confirm that setting currentWindow: true works best for me and should be set back.

@xpl
Copy link
Owner Author

xpl commented Sep 18, 2018

@oneezy Thanks for the feedback. I'm setting the currentWindow back to true then (until there is an overwhelming evidence that the false setting is better...). And this open issue will hang there for a while.

xpl added a commit that referenced this issue Sep 18, 2018
@xpl xpl closed this as completed Feb 27, 2019
@smcllns
Copy link

smcllns commented Jun 6, 2020

I've been periodically trying to debug/improve this while working on an extension. Having current window set to true or false both works and fails for me, and it's hard to debug why.

It's not perfect but as a practical suggestion, I'm find using lastFocusedWindow instead of currentWindow a better experience because it's more predictable (if it doesn't refresh, it's because I had last focused on a different Chrome window).

chrome.tabs.query({ active: true, lastFocusedWindow: true }, (tabs) => {
    if (tabs[0]) {
      chrome.tabs.reload(tabs[0].id);
    }
    chrome.runtime.reload();
  });

@xpl
Copy link
Owner Author

xpl commented Jun 6, 2020

@smcllns Thank you for your response! I'll reopen the issue for now (let's see if there's more feedback coming), also will try your suggestion soon – there are going to be changes (e.g. adding file exclusion/inclusion, thanks to @mikob's work), so I'll try to find the time to wrap this all up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants