Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub icon should not appear on user pages #39

Open
JayFoxRox opened this issue Feb 7, 2019 · 0 comments
Open

GitHub icon should not appear on user pages #39

JayFoxRox opened this issue Feb 7, 2019 · 0 comments
Labels
infrastructure Issues which affect the website itself (style / reachability). user Problems in the user section.

Comments

@JayFoxRox
Copy link
Member

Currently, the GitHub icon is always shown in the upper right.

I don't think this is a good idea, as users are not the target audience for that.

I think it's fine to just remove the button from all pages. Our developer page refers to GitHub in the first sentence anyway. If we can figure it out, we can also display it on the Developers tab, but showing it everywhere is probably not good.
@DiscoStarslayer DiscoStarslayer mentioned this issue May 24, 2019
Closed
@JayFoxRox JayFoxRox added infrastructure Issues which affect the website itself (style / reachability). user Problems in the user section. labels May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Issues which affect the website itself (style / reachability). user Problems in the user section.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide github icon unless on developer page DiscoStarslayer/xqemu.com
1 participant
@JayFoxRox