Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regular "text" shapes to allow editing #1

Open
xsrf opened this issue Jan 19, 2021 · 1 comment
Open

Use regular "text" shapes to allow editing #1

xsrf opened this issue Jan 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@xsrf
Copy link
Owner

xsrf commented Jan 19, 2021

Regular text shapes are also drawn using an SVG that is independent of the actual text.
The text attribute could hold the label text and also the settings used to create it (e.g. as json string).
Assigning a fake font face prevents EasyEDA from trying to redraw the shape, so the actual SVG should be preserved.
This would allow future editing of labels within the extension.

@xsrf xsrf added the enhancement New feature or request label Jan 25, 2021
@xsrf
Copy link
Owner Author

xsrf commented Aug 3, 2022

One issue though: https://easyeda.com/forum/topic/Changing-height-of-text-with-unknown-font-redraws-it-without-asking-0e2a7e72ce3443aca623996025d49401
Changing the height of a text redraws it with the default font immediately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant