Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake install fails to install all headers #57

Closed
hansenms opened this issue Oct 19, 2021 · 5 comments
Closed

CMake install fails to install all headers #57

hansenms opened this issue Oct 19, 2021 · 5 comments

Comments

@hansenms
Copy link

When following the install instructions: https://github.com/xtensor-stack/xtensor-fftw#installation

The required headers do not get installed, e.g. basic_float.hpp, which is included from basic.hpp does not get installed.

This is, I believe, because ${XTENSOR_FFTW_HEADERS} is defined here without those headers:

https://github.com/xtensor-stack/xtensor-fftw/blob/master/CMakeLists.txt#L179

@egpbos
Copy link
Member

egpbos commented Oct 25, 2021

Seems completely right! Do you think you have time to make a PR to fix this?

@hansenms
Copy link
Author

I can certainly make a PR to add those lines, but my bigger concern would be how this gets tested?

@hansenms
Copy link
Author

Actually looks like somebody else ran into this and there is a PR:
#55

@egpbos
Copy link
Member

egpbos commented Oct 26, 2021

Oops, I completely missed that one. Thanks for the pointer.

@egpbos
Copy link
Member

egpbos commented Oct 26, 2021

I share your concern about testing btw. See #59.

@egpbos egpbos closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants