-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake install fails to install all headers #57
Comments
Seems completely right! Do you think you have time to make a PR to fix this? |
I can certainly make a PR to add those lines, but my bigger concern would be how this gets tested? |
Actually looks like somebody else ran into this and there is a PR: |
Oops, I completely missed that one. Thanks for the pointer. |
I share your concern about testing btw. See #59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When following the install instructions: https://github.com/xtensor-stack/xtensor-fftw#installation
The required headers do not get installed, e.g.
basic_float.hpp
, which is included frombasic.hpp
does not get installed.This is, I believe, because
${XTENSOR_FFTW_HEADERS}
is defined here without those headers:https://github.com/xtensor-stack/xtensor-fftw/blob/master/CMakeLists.txt#L179
The text was updated successfully, but these errors were encountered: