Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligatures background color can flash the wrong color when moving to different lines #5206

Closed
Tyriar opened this issue Nov 4, 2024 · 0 comments · Fixed by #5209
Closed

Ligatures background color can flash the wrong color when moving to different lines #5206

Tyriar opened this issue Nov 4, 2024 · 0 comments · Fixed by #5209
Assignees
@Tyriar
Labels
area/addon/ligatures area/addon/webgl type/bug Something is misbehaving
Milestone
6.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 4, 2024

Image

Likely the same root cause as #5205
@Tyriar Tyriar added this to the 6.0.0 milestone Nov 4, 2024
@Tyriar Tyriar self-assigned this Nov 4, 2024
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 4, 2024
@Tyriar
Ensure last ligature cell is updated
129cbd8 
Fixes xtermjs#5207
Fixes xtermjs#3288
Fixes xtermjs#5206
Part of microsoft/vscode#233005
@Tyriar Tyriar mentioned this issue Nov 4, 2024
Merged
@Tyriar Tyriar closed this as completed in 7fab293 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/ligatures area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Ensure last ligature cell is updated Tyriar/xterm.js
1 participant
@Tyriar