forked from salesforce/design-system-react
-
Notifications
You must be signed in to change notification settings - Fork 0
/
.eslintrc.js
272 lines (261 loc) · 8.1 KB
/
.eslintrc.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
module.exports = {
extends: ['eslint-config-airbnb', 'prettier', 'prettier/react'],
parser: 'babel-eslint',
parserOptions: {
ecmaVersion: 7,
sourceType: 'module',
ecmaFeatures: {
classes: true,
experimentalObjectRestSpread: true,
impliedStrict: true,
jsx: true,
modules: true,
},
},
plugins: [
'filenames',
'fp',
'json',
'prefer-object-spread',
'@salesforce/slds-react',
'react-hooks',
],
env: {
browser: true,
},
settings: {
react: {
pragma: 'React',
version: 'detect',
},
},
overrides: [
{
// Storybook and site examples
files: [
'**/__examples__/**/*.{js,jsx}',
'**/__docs__/**/*.{js,jsx}',
'**/site-stories.js',
],
rules: {
// devDependencies are used
'import/no-extraneous-dependencies': 'off',
// console is used in examples
'no-console': 'off',
// TODO: This should be removed.
'no-unused-vars': 'off',
'react/no-access-state-in-setstate': 'off',
'react/jsx-no-literals': ['off'],
// FUNTIONAL RULES
'fp/no-arguments': 'off',
'fp/no-delete': 'off',
'fp/no-events': 'off',
'fp/no-get-set': 'off',
'fp/no-loops': 'off',
'fp/no-mutating-assign': 'off',
'fp/no-mutating-methods': 'off',
'fp/no-proxy': 'off',
'fp/no-rest-parameters': 'off',
'fp/no-throw': 'off',
'fp/no-valueof-field': 'off',
},
},
{
// Utility scripts
files: ['./*.js', 'preset/*.js', 'scripts/*.js', '**/site-stories.js'],
rules: {
// devDependencies are used
'import/no-extraneous-dependencies': 'off',
// Utility scripts use many types of loaders
'import/no-webpack-loader-syntax': 'off',
// console is used in scripts
'no-console': 'off',
// FUNTIONAL RULES
'fp/no-arguments': 'off',
'fp/no-delete': 'off',
'fp/no-events': 'off',
'fp/no-get-set': 'off',
'fp/no-loops': 'off',
'fp/no-mutating-assign': 'off',
'fp/no-mutating-methods': 'off',
'fp/no-proxy': 'off',
'fp/no-rest-parameters': 'off',
'fp/no-throw': 'off',
'fp/no-valueof-field': 'off',
},
},
{
// Test files
files: ['**/__tests__/**/*.{js,jsx}', 'tests/*.{js,jsx}'],
env: {
browser: true,
jest: true,
mocha: true,
},
globals: {
chai: true,
jest: true,
sinon: true,
},
rules: {
'func-names': 'off',
// devDependencies are used
'import/no-extraneous-dependencies': 'off',
// console is used in tests
'no-console': 'off',
// TODO: This should be removed.
'no-unused-expressions': 'off',
// TODO: This should be removed.
'prefer-arrow-callback': 'off',
// TODO: This should be removed.
'react/display-name': 'off',
'react/no-access-state-in-setstate': 'off',
'react/jsx-no-literals': ['off'],
// FUNTIONAL RULES
'fp/no-arguments': 'off',
'fp/no-delete': 'off',
'fp/no-events': 'off',
'fp/no-get-set': 'off',
'fp/no-loops': 'off',
'fp/no-mutating-assign': 'off',
'fp/no-mutating-methods': 'off',
'fp/no-proxy': 'off',
'fp/no-rest-parameters': 'off',
'fp/no-throw': 'off',
'fp/no-valueof-field': 'off',
},
},
{
// ESLint Plugin
files: ['eslint-plugin/**/*.js'],
rules: {
'import/no-extraneous-dependencies': 'off',
'@salesforce/slds-react/no-double-dash-modifier': 'off',
},
},
],
// Please review Prettier settings for style linting
rules: {
'linebreak-style': [
2,
process.env.OS && process.env.OS.match(/Windows/) ? 'windows' : 'unix',
],
// Creates consistent filename case: "kabob case"
'filenames/match-regex': [2, '^[a-z\\-\\.]+$', true],
// All imported files are JSX or JS
'import/extensions': 'off',
// `~` is used by examples for "root" npm package in documentation site
'import/no-unresolved': [2, { ignore: ['^[~]'] }],
'no-multi-spaces': [
2,
{
// allows "column spacing." Following key names are Abstract Syntax Tree types
exceptions: {
VariableDeclarator: true,
Property: true,
ImportDeclaration: true,
AssignmentExpression: true,
JSXAttribute: true,
},
},
],
// _ is not really private.
'no-underscore-dangle': ['error', { allowAfterThis: true }],
//
'prefer-object-spread/prefer-object-spread': [2, 'always'],
'react/jsx-fragments': ['error', 'element'],
'max-lines': [
'error',
{ max: 500, skipBlankLines: true, skipComments: true },
],
// Can't be used because it doesn't currently recognize props used in functions
'react/no-unused-prop-types': 'off',
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-literals.md
// All text should be able to be changed by the consumer due to internationalisation
// See https://github.com/salesforce/design-system-react/blob/master/docs/codebase-overview.md#rendered-text-needs-a-prop-group-assistive-text-and-labels
'react/jsx-no-literals': ['error', { noStrings: false }],
// FUNTIONAL RULES
'fp/no-arguments': 'error',
// 'fp/no-class': 'error',
'fp/no-delete': 'error',
'fp/no-events': 'error',
'fp/no-get-set': 'error',
// 'fp/no-let': 'error',
'fp/no-loops': 'error',
'fp/no-mutating-assign': 'error',
'fp/no-mutating-methods': 'error',
// 'fp/no-mutation': 'error',
// 'fp/no-nil': 'error',
'fp/no-proxy': 'error',
'fp/no-rest-parameters': 'error',
// 'fp/no-this': 'error',
'fp/no-throw': 'error',
// 'fp/no-unused-expression': 'error',
'fp/no-valueof-field': 'error',
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'error',
//
// THE FOLLOWING RULES NEED REVIEW IN THE FUTURE (and possibly removed)
//
// When someone is ready to tackle these issues, feel free to tighten
// the following rules. Do not push a change that causes lint errors/warnings
// to start appearing. All lint warnings errors should be meaningful, and
// therefore, there should never intentionally be any.
// We are open to changing this to always use a trailing comma,
// in order to make re-sorting easier
'comma-dangle': [2, 'only-multiline'],
'import/no-useless-path-segments': 'off',
// Should be removed in the future. `event` is the main global used now.
'no-restricted-globals': 'off',
// Would prefer all mixed operators as errors, but this conflicts
// with Prettier
'no-mixed-operators': [
'error',
{
groups: [
// ["+", "-", "*", "/", "%", "**"], // imcompatible with prettier
['&', '|', '^', '~', '<<', '>>', '>>>'],
['==', '!=', '===', '!==', '>', '>=', '<', '<='],
['&&', '||'],
['in', 'instanceof'],
],
allowSamePrecedence: true,
},
],
'react/destructuring-assignment': ['error', { ignoreClassFields: true }],
// May consider removing. Would be unable to test for undefined props.
'react/default-props-match-prop-types': 'off',
// TODO: Should be removed
'react/no-unused-state': 'off',
// TODO: Should be removed
'react/prop-types': 'off',
// Used to prevent usage of any, array, and object but may be too strict currently
'react/forbid-prop-types': 'off',
// TODO: Should be removed
'react/no-multi-comp': 'off',
// Don't throw errors when explicit defaults aren't set
'react/require-default-props': 'off',
// Components that are top-level should be classes, so the DOM ref exists
'react/prefer-stateless-function': 'off',
// TODO: Should be removed
'react/no-deprecated': 'off',
// <a href="#"> is present in SLDS markup
'jsx-a11y/anchor-is-valid': 'off',
'jsx-a11y/aria-activedescendant-has-tabindex': 2,
'jsx-a11y/interactive-supports-focus': 2,
'jsx-a11y/no-autofocus': 2,
'jsx-a11y/no-interactive-element-to-noninteractive-role': 2,
'jsx-a11y/no-noninteractive-element-interactions': 2,
'jsx-a11y/no-noninteractive-tabindex': 2,
'jsx-a11y/no-redundant-roles': 2,
'jsx-a11y/role-has-required-aria-props': 2,
// Many labels have htmlFor, but are still errors
'jsx-a11y/label-has-for': 'off',
// TODO: Should be removed. All mouse interactions should be able
// to be done with the keyboard.
'jsx-a11y/click-events-have-key-events': 'off',
'jsx-a11y/label-has-associated-control': 'off',
// Enforce single underscore modifiers for BEM class names
'@salesforce/slds-react/no-double-dash-modifier': 'error',
},
};