Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup stale snapshots #45

Open
xuset opened this issue Feb 12, 2017 · 5 comments
Open

Cleanup stale snapshots #45

xuset opened this issue Feb 12, 2017 · 5 comments
Assignees

Comments

@xuset
Copy link
Owner

xuset commented Feb 12, 2017

Snapshots should automatically be cleanup when they are stale or the cleanup functionality should be exposed in the api.

@xuset
Copy link
Owner Author

xuset commented Apr 25, 2017

In the service worker, after update() is called the old snapshots should be removed. This can be accomplished by retrieving the list of snapshots, getAllSnapshots(), and then calling remove() on those snapshots excluding the most recent snapshot.

@georgeaf99
Copy link
Collaborator

@xuset @alvin319 Shouldn't this be handled in update? I thought we were looking to depreciate the snapshots interface from Planktos?

@xuset
Copy link
Owner Author

xuset commented Apr 26, 2017

For it to be handled in update() the interface has to change first which seems out of scope for this issue

@georgeaf99
Copy link
Collaborator

I'm not sure I see why the interface would have to change? The update function gets the latest snapshot, so it could just delete all the other ones after it finishes storing the new snapshot.

@xuset
Copy link
Owner Author

xuset commented Apr 26, 2017

The existing interface doesn't make sense when there can only be one snapshot. getAllSnapshots and removeSnapshot are pointless when there is only one snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants