Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Editing #57

Open
1 of 8 tasks
georgeaf99 opened this issue Mar 18, 2017 · 0 comments
Open
1 of 8 tasks

Tag Editing #57

georgeaf99 opened this issue Mar 18, 2017 · 0 comments

Comments

@georgeaf99
Copy link
Collaborator

georgeaf99 commented Mar 18, 2017

Previous Discussion in #53

Terminology: Intercept mechanism refers to the way in which a request is intercepted e.g. service worker or tag editing. Intercept handler refers to the piece of code which decides how an intercepted request should be handled.

To Do:

  • Add a folder for different implementations of intercept handlers (for right now it should only contain default.js)
  • Separate out the intercept handler from sw.js into default.js (service worker specific code should remain)
  • Replace the Planktos fetch interface with something that is agnostic to intercept mechanism (right now it accepts a FetchEvent)
  • Add a flag for selecting which intercept mechanisms to use
  • Add a build phase in the CLI that calls the tag editor
  • Inject the Planktos install script into every JS file during build phase
  • Create a standard for modifying resource tags (feature request: simplify render api webtorrent/webtorrent#879 (comment))
  • Handle editing of all tags (<audio>, <base>, <iframe>, <img>, <link>, <object>, <picture>, <source>, <track>, <video>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant