Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace drawio PDF export with drawio File -> Print action #288

Open
snazare opened this issue Oct 3, 2024 · 0 comments · Fixed by #321 · May be fixed by #324
Open

Replace drawio PDF export with drawio File -> Print action #288

snazare opened this issue Oct 3, 2024 · 0 comments · Fixed by #321 · May be fixed by #324
Assignees
@Farcasut
Labels
Type: Task
Milestone
1.22

Comments

@snazare
Copy link

snazare commented Oct 3, 2024 •
edited by oanalavinia
Loading

This issue is a follow-up on #270

Right now, clicking on File -> Export As -> PDF will produce an empty PDF. This functionality should now be replaced by the File -> Print (from the editor) action, which should produce the same result (will also include all pages)

Investigation done so far: #270 (comment)
This was referenced Oct 3, 2024
Closed
Closed
Closed
@snazare snazare removed the ToSchedule label Oct 3, 2024
@oanalavinia oanalavinia changed the title Replace drawio pdf export with browser print Replace drawio pdf export with drawio File -> Print action Nov 8, 2024
@oanalavinia oanalavinia changed the title Replace drawio pdf export with drawio File -> Print action Replace drawio PDF export with drawio File -> Print action Nov 8, 2024
Farcasut added a commit that referenced this issue Nov 27, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288
8b5d482 
 Updated the code to rename the Print button to export pdf and removed the original export as pdf button
@Farcasut Farcasut linked a pull request Nov 27, 2024 that will close this issue
Replace drawio PDF export with drawio File -> Print action #288 #321
Merged
Farcasut added a commit that referenced this issue Nov 29, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288 (#321)
2f8e006 
Updated the code to rename the Print button to export pdf and removed the original export as pdf button
@Farcasut Farcasut reopened this Dec 2, 2024
Farcasut added a commit that referenced this issue Dec 2, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288
b8f0479
@Farcasut Farcasut linked a pull request Dec 2, 2024 that will close this issue
Replace drawio PDF export with drawio File -> Print action #288 #324
Open
@oanalavinia oanalavinia added this to the 1.22 milestone Dec 3, 2024
@oanalavinia oanalavinia moved this from Done to In Progress in Pro Apps Roadmap October - November 2024 Dec 3, 2024
Farcasut added a commit that referenced this issue Dec 3, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288
72f6e5a 
Update the code to use translations.
Farcasut added a commit that referenced this issue Dec 3, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288
86cfa83 
Removed new line.
Farcasut added a commit that referenced this issue Dec 3, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288
2323db5 
Removed new line.
Farcasut added a commit that referenced this issue Dec 3, 2024
@Farcasut
Replace drawio PDF export with drawio File -> Print action #288
687d65b 
Refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farcasut Farcasut

Labels
Type: Task
Projects
Pro Apps Roadmap October - November 2024
Status: In Progress
Milestone
1.22
3 participants
@oanalavinia @snazare @Farcasut