You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
WP Dev Lib currently supports the outdated WordPress-VIP coding standards ruleset that will no longer be supported as of WPCS 2.0.0. Currently, when we pull the WPCS project, we checkout the develop branch which is the beta of 2.0.0 and thus, builds fail when trying to use the WordPress-VIP rules.
The solution is to incorporate https://github.com/Automattic/VIP-Coding-Standards/, but a decision needs to be made on how to include those rules. Should we always install them? Should we selectively include them based on the specified rules of the current project? That would be the most obvious, but is more complex as we would need to parse the rules file in the check-diff.sh script.
The text was updated successfully, but these errors were encountered:
If VIP-Coding-Standards is installed with composer along with WPCS and PHPCS, then it should all work fine as it is today. The AMP plugin is using PHPCompatibility even though wp-dev-lib doesn't know anything about it specifically:
WP Dev Lib currently supports the outdated
WordPress-VIP
coding standards ruleset that will no longer be supported as of WPCS 2.0.0. Currently, when we pull the WPCS project, we checkout thedevelop
branch which is the beta of 2.0.0 and thus, builds fail when trying to use theWordPress-VIP
rules.The solution is to incorporate https://github.com/Automattic/VIP-Coding-Standards/, but a decision needs to be made on how to include those rules. Should we always install them? Should we selectively include them based on the specified rules of the current project? That would be the most obvious, but is more complex as we would need to parse the rules file in the
check-diff.sh
script.The text was updated successfully, but these errors were encountered: