Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nested scrolling counts in GONE and INVISIBLE view which is not correct #15

Open
Jenna233 opened this issue May 4, 2018 · 1 comment
Open

nested scrolling counts in GONE and INVISIBLE view which is not correct #15

Jenna233 opened this issue May 4, 2018 · 1 comment

Comments

@Jenna233
Copy link

Jenna233 commented May 4, 2018

In canViewScrollUp and canViewScrollHorizontally check every view of parent , including the invisible ones which is wrong. In my project, some views are invisible, they should not be considered in nested scrolling.
@Jenna233
Copy link
Author

Jenna233 commented May 4, 2018

I think it's better for CustomSwipeLayout to implement NestedScrollingParent and NestedScrollingChild to support nested scrolling, this is the way the android system supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jenna233